Skip to content

Conversation

@sethidden
Copy link
Contributor

@sethidden sethidden commented Jun 27, 2022

I refactored the Checkout and Billing pages a bit because it's the 2nd time something is returing from a retest and I was tired of the outdated logic in those components.

  1. addressId are now always numbers (that's how they come from the api). String casts are used only when a function somewhere deeper down the line needs it
  2. simplify logic of detecting whether the default address should be preselected. Preselection should only happen if a shipping/billing address weren't previously set on the cart. The logic from before PR doesn't quite work since the form approach changed since then
  3. Make UserBillingAddresses use two way binding for selecting the address, rather than an internal computed. This re-introduces the behavior seen in M2-333 but that's intended
  4. Show country name instead of country code in "billing address is the same as shipping" address card

M2-869

@sethidden sethidden marked this pull request as draft June 28, 2022 09:54
@sethidden sethidden force-pushed the M2-869-cant-finalize-order-billing branch 4 times, most recently from ca3b964 to 882dc45 Compare June 28, 2022 14:45
@sethidden sethidden marked this pull request as ready for review June 28, 2022 14:45
@sethidden sethidden changed the title fix: old detection of an address being previously set not working refactor(checkout): simplify billing/checkout logic Jun 28, 2022
@sethidden sethidden force-pushed the M2-869-cant-finalize-order-billing branch from 882dc45 to 895a063 Compare June 28, 2022 14:51
M2-757
M2-869

chore: fix commit wording

refactor: don't redundantly hide form addition
@sethidden sethidden force-pushed the M2-869-cant-finalize-order-billing branch from 895a063 to 5fe749e Compare June 28, 2022 14:54
@Frodigo Frodigo added this to the 1.0.0-rc.10 milestone Jun 29, 2022
@sethidden sethidden merged commit 89a6658 into develop Jun 29, 2022
@sethidden sethidden deleted the M2-869-cant-finalize-order-billing branch June 29, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants