fix: when changing itemsPerPage, also reset page to 0 #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consider this case: - there are 11 items - itemsPerPage is 10 - so there are 2 pages - you go to page 2 - you change itemsPerPage to 100 - now there's just 1 page, to be precise: 11 items on the first page - the 2nd page shows nothing before this commit if the above situation happened, you'd just get a "no results" page - i think it's safer to redirect to page 0 when changing itemsPerPage to avoid the case described above M2-862
sethidden
force-pushed
the
M2-862-my-account-empty-after-changing-pages
branch
from
a591c6c to
3b22ca0
Compare
Frodigo
approved these changes
Jun 27, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consider this case:
before this commit if the above situation happened, you'd just get a "no
results" page - i think it's safer to redirect to page 0 when changing
itemsPerPage to avoid the case described above