Skip to content

fix(category): fix various rwd issues on category mobile view #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

fix(category): fix various rwd issues on category mobile view #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
276e1bc
fix(category): prevent containers wider than viewport on mobile
sethidden Jun 24, 2022
18c34a8
fix(category): last card in first row larger than rest of cards
sethidden Jun 24, 2022
f432010
fix(category): filters btn offscreen on 320px wide viewport
sethidden Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/theme/modules/catalog/category/components/navbar/CategoryNavbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default defineComponent({
align-content: center;
border: 1px solid var(--c-light);
border-width: 0 0 1px 0;
padding: var(--spacer-sm);
padding: var(--spacer-sm) var(--spacer-xs);;

@include for-desktop {
border-width: 1px 0 1px 0;
Expand Down Expand Up @@ -216,7 +216,6 @@ export default defineComponent({
}

&__select {
--select-width: 185px;
--select-padding: 0;
--select-height: auto;
--select-selected-padding: 0 var(--spacer-lg) 0 var(--spacer-2xs);
Expand Down Expand Up @@ -250,6 +249,11 @@ export default defineComponent({
order: 1;
display: flex;
align-items: center;

margin: {
left: var(--spacer-xs);
right: var(--spacer-xs);
}
@include for-desktop {
margin: auto 0 auto auto;
order: 0;
Expand Down
7 changes: 3 additions & 4 deletions packages/theme/modules/catalog/category/components/views/CategoryProductGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,15 @@ export default defineComponent({
}
}
.card {
--product-card-title-margin: var(--spacer-base) 0 0 0;
--product-card-title-font-weight: var(--font-weight--medium);
--product-card-title-margin: var(--spacer-xs) 0 0 0;
flex: 1 1 50%;
flex: 1 1 100%;

@include for-desktop {
flex: 1 1 23%;
--product-card-max-width: 25%;
--product-card-title-font-weight: var(--font-weight--normal);
--product-card-add-button-bottom: var(--spacer-base);
--product-card-title-margin: var(--spacer-sm) 0 0 0;
--product-card-add-button-bottom: var(--spacer-base);
}
}

Expand Down
8 changes: 5 additions & 3 deletions packages/theme/modules/catalog/pages/category.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,12 @@ export default defineComponent({

.main {
&.section {
padding: var(--spacer-xs);
padding: 0;

@include for-desktop {
padding: 0;
@include for-mobile {
$padding: var(--spacer-xs);
padding: $padding;
width: calc(100% - 2 * $padding);
}
}
}
Expand Down