ci: shorten pr name lint action runtime from 90s to 20s #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-360
branch
2 times, most recently
from
118a13f to
19d5892
Compare
Frodigo
previously approved these changes
Jun 24, 2022
sethidden
force-pushed
the
M2-360
branch
2 times, most recently
from
2eb8005 to
5091e4c
Compare
sethidden
changed the title
Contributor
Author
|
@Frodigo Turned out that the first version accepted was actually downloading all packages nonetheless. Installing only one package is only achievable by removing package.json, but it's fine for our case since this is a self-contained check for just the commit. |
sethidden
changed the title
sethidden
changed the title
Frodigo
approved these changes
Jun 24, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, 700mb of node_modules (all app dependencies) were fetched just to commitlint, which took a long time.
After it, just the needed package is fetched.
M2-360