fix(checkout): find addresses with numeric id #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user addresses are returned by the backend with addressId being of type `number` but for some reason we were looking for them using the addressId casted to `string`, so they were never found. userShippingGetters.getAddress matches criteria based on strict type checking `===` so that's why the eg. addressId String(131) did not match Number(131) M2-755
Frodigo
approved these changes
Jun 24, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user addresses are returned by the backend with addressId being of type
numberbut for some reason we were looking for them using the addressId casted
to
string, so they were never found.userShippingGetters.getAddress matches criteria based on strict type
checking
===so that's why the eg. addressId String(131) did not match Number(131)M2-755