fix: cart store not cleared properly on logout #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The initial resolution doesn't work - clear() is necessary to add a new cart so it's possible to add products after logging out |
there's logic inside clear() that creates a fresh cart if there's no cart id before this commit there seems to have been a race condition between logout and clear
sethidden
force-pushed
the
M2-831-cart-is-not-cleared-after-log-out
branch
from
07bbd40 to
a72af1e
Compare
Contributor
Author
|
Should be ok now |
Frodigo
reviewed
Jun 23, 2022
Frodigo
approved these changes
Jun 23, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit if you - while logged in - added some new items to
the cart, then logged out, the cart store would still contain the full,
old cart object
This was caused by the useCart().clear() method patching the cart
store (similarly to useUser().setCart()), and it seems like there was a
race condition there. Please note .clear() re-downloads the cart
M2-831