fix: move user to first page of products after applying filters #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this commit, the page number remained unchanged after changing filters this was as problem in the scenario where: 1. open the category Women - it has 8 pages by default 2. go to page 8 3. apply some filter - eg. select "Capri" in the Material section 4. the `yarn dev` console where nuxt is running will report errors like "currentPage value 8 specified is greater than the X page(s) available" you can't know how many pages a filter will return so always returning to first page makes sense this also works ok if no products are returned
Frodigo
approved these changes
Jun 21, 2022
sethidden
deleted the
M2-667-current-page-value-2-specified-is-greater-than-the-1-pages-available
branch
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this commit, the page number remained unchanged after changing filters
this was as problem in the scenario where:
yarn devconsole where nuxt is running will report errors like"currentPage value 8 specified is greater than the X page(s) available"
you can't know how many pages a filter will return so always returning
to first page makes sense
this also works ok if no products are returned