fix!: product pricing #1146
Merged
fix!: product pricing #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frodigo
force-pushed
the
M2-668-product-page-price-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details
branch
2 times, most recently
from
85e3187 to
2e368c4
Compare
sethidden
requested changes
Jun 22, 2022
packages/theme/modules/catalog/product/components/product-types/bundle/BundleProduct.vue
Outdated
Show resolved
Hide resolved
...heme/modules/catalog/product/components/product-types/bundle/BundleProductOptionSkeleton.vue
Show resolved
Hide resolved
packages/theme/modules/catalog/product/components/product-types/bundle/BundleProduct.vue
Outdated
Show resolved
Hide resolved
Frodigo
force-pushed
the
M2-668-product-page-price-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details
branch
from
2e368c4 to
1d1b101
Compare
sethidden
reviewed
Jun 23, 2022
packages/theme/modules/catalog/pricing/getGroupedProductPriceCommand.ts
Outdated
Show resolved
Hide resolved
sethidden
reviewed
Jun 23, 2022
packages/theme/modules/catalog/product/components/product-types/bundle/BundleProduct.vue
Outdated
Show resolved
Hide resolved
Frodigo
force-pushed
the
M2-668-product-page-price-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details
branch
3 times, most recently
from
d088796 to
c1e79ab
Compare
Frodigo
force-pushed
the
M2-668-product-page-price-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details
branch
from
c1e79ab to
7683728
Compare
sethidden
approved these changes
Jun 23, 2022
Frodigo
deleted the
M2-668-product-page-price-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details
branch
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for price calculation on PDP.
Before
Before this PR, products' prices of different currencies than default were cached in Redis
After
From now, prices are not saved in Redis and loaded on the client-side dynamically so it's possible to see prices in all available currencies on the product page.