Skip to content

fix: pressing enter should search immediately #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: pressing enter should search immediately #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/theme/components/Header/SearchBar/SearchBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
aria-label="Search"
class="sf-header__search"
:value="term"
@input="handleSearch"
@keydown.enter="handleSearch($event)"
@input="debouncedHandleSearch($event)"
@keyup.enter="handleKeydownEnter($event.target.value) /* https://github.com/vuestorefront/storefront-ui/issues/2453#issuecomment-1160231619 */"
@keydown.tab="hideSearch"
@focus="showSearch"
@click="showSearch"
Expand Down Expand Up @@ -130,7 +130,7 @@ export default defineComponent({
}
};

const handleSearch = debounce(async (searchTerm: string) => {
const rawHandleSearch = async (searchTerm: string) => {
term.value = searchTerm;
if (term.value.length < props.minTermLen) return;

Expand All @@ -141,7 +141,15 @@ export default defineComponent({
}) as unknown as Products;

emit('set-search-results', productList!.items);
}, 1000);
};

const debouncedHandleSearch = debounce(rawHandleSearch, 1000);

const handleKeydownEnter = (searchTerm: string) => {
// cancel debounce timeout started by typing into the searchbar - this is to avoid making two network requests instead of one
debouncedHandleSearch.cancel();
rawHandleSearch(searchTerm);
};

watch(route, () => {
hideSearch();
Expand All @@ -153,7 +161,9 @@ export default defineComponent({
showSearch,
hideSearch,
toggleSearch,
handleSearch,
rawHandleSearch,
debouncedHandleSearch,
handleKeydownEnter,
term,
};
},
Expand Down