Skip to content

fix: wishlist amount of displayed products is changed after v… #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: wishlist amount of displayed products is changed after v… #1130

merged 1 commit into from
Jun 17, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 15, 2022 •
edited
Loading

Description

add parameter do decide if useWishlist should load data into store or just return

Related Issue

#1049

Motivation and Context

How Has This Been Tested?

  1. Login.
  2. Add > 10 products to Wishlist.
  3. Refresh the page.
  4. Go to My account.
  5. Open My wishlist.
  6. Switch to the second page.
  7. Open wishlist from top menu.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-620-wishlist-amount-of-displayed-products-is-changed-after-visiting-my-account-my-wishlist branch 2 times, most recently from eebea42 to 2eedb18 Compare June 15, 2022 09:21
@bartoszherba bartoszherba marked this pull request as draft June 15, 2022 09:37
@bartoszherba bartoszherba force-pushed the M2-620-wishlist-amount-of-displayed-products-is-changed-after-visiting-my-account-my-wishlist branch 2 times, most recently from f2dc0f4 to 88d01ab Compare June 15, 2022 10:53
@bartoszherba bartoszherba force-pushed the M2-620-wishlist-amount-of-displayed-products-is-changed-after-visiting-my-account-my-wishlist branch from 88d01ab to 164098b Compare June 15, 2022 10:54
@bartoszherba bartoszherba marked this pull request as ready for review June 15, 2022 10:55
@Frodigo Frodigo added this to the 1.0.0-rc.10 milestone Jun 15, 2022
@Frodigo Frodigo merged commit e8cc779 into develop Jun 17, 2022
@Frodigo Frodigo deleted the M2-620-wishlist-amount-of-displayed-products-is-changed-after-visiting-my-account-my-wishlist branch June 17, 2022 14:53
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
fix: m2-620. wishlist amount of displayed products is changed after v…
7c66b08 
…isiting my account wishlist (#1130)
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
fix: m2-620. wishlist amount of displayed products is changed after v…
8d2f83a 
…isiting my account wishlist (#1130)
Frodigo pushed a commit that referenced this pull request Jul 4, 2022
@bartoszherba
fix: m2-620. wishlist amount of displayed products is changed after v…
1630a02 
…isiting my account wishlist (#1130)
@Frodigo Frodigo changed the title fix: m2-620. wishlist amount of displayed products is changed after v… fix: wishlist amount of displayed products is changed after v… Jul 4, 2022
This was referenced Jul 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden Awaiting requested review from sethidden

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.10

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo