Skip to content

fix: fix pagination on mobile wishlist view #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix: fix pagination on mobile wishlist view #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 45 additions & 32 deletions packages/theme/modules/customer/pages/MyAccount/MyWishlist.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,40 +75,41 @@
"
/>
</transition-group>
<LazyHydrate on-interaction>
<SfPagination
v-if="!loading"
v-show="pagination.totalPages > 1"
class="products__pagination desktop-only"
:current="pagination.currentPage"
:total="pagination.totalPages"
:visible="5"
/>
</LazyHydrate>

<div
v-show="pagination.totalPages > 1"
class="products__show-on-page"
>
<span class="products__show-on-page__label">
{{ $t('Show on page') }}
</span>
<div class="products__display-opt">
<LazyHydrate on-interaction>
<SfSelect
:value="pagination.itemsPerPage.toString()"
class="products__items-per-page"
@input="th.changeItemsPerPage"
>
<SfSelectOption
v-for="option in pagination.pageOptions"
:key="option"
:value="option"
class="products__items-per-page__option"
>
{{ option }}
</SfSelectOption>
</SfSelect>
<SfPagination
v-if="!loading"
v-show="pagination.totalPages > 1"
class="products__pagination"
:current="pagination.currentPage"
:total="pagination.totalPages"
:visible="5"
/>
</LazyHydrate>
<div
v-show="pagination.totalPages > 1"
class="products__show-on-page"
>
<span class="products__show-on-page__label">
{{ $t('Show on page') }}
</span>
<LazyHydrate on-interaction>
<SfSelect
:value="pagination.itemsPerPage.toString()"
class="products__items-per-page"
@input="th.changeItemsPerPage"
>
<SfSelectOption
v-for="option in pagination.pageOptions"
:key="option"
:value="option"
class="products__items-per-page__option"
>
{{ option }}
</SfSelectOption>
</SfSelect>
</LazyHydrate>
</div>
</div>
</div>
</SfLoader>
Expand Down Expand Up @@ -506,6 +507,18 @@ export default defineComponent({
font-size: var(--font-size--sm);
}
}

&__display-opt {
display: flex;
justify-content: space-around;
align-items: center;

@include for-mobile {
.sf-pagination {
margin-bottom: 10px;
}
}
}
}

.loading {
Expand Down