Skip to content

feat: add quantity error message on the PDP when adding to the cart #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

feat: add quantity error message on the PDP when adding to the cart #1123

merged 1 commit into from
Jun 13, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 13, 2022 •
edited
Loading

Description

add quantity error message on the PDP when adding to the cart

Related Issue

#1013

Motivation and Context

How Has This Been Tested?

  1. Open any product page.
  2. Add more items than available quantity - 100 or 200 should be enough.
  3. Hit "Add to cart" button.
  4. Repeat for all types of products.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-590-product-page-type-error-in-the-console-and-missing-not-enough-quantity-information-when-user-add-than-available-quantity branch from 3d501a9 to a5ef670 Compare June 13, 2022 11:59
@Frodigo Frodigo added this to the 1.0.0-rc.10 milestone Jun 13, 2022
@Frodigo Frodigo merged commit 9b5e81b into develop Jun 13, 2022
@Frodigo Frodigo deleted the M2-590-product-page-type-error-in-the-console-and-missing-not-enough-quantity-information-when-user-add-than-available-quantity branch June 13, 2022 12:15
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
feat: add quantity error message on the PDP when adding to the cart (#…
a017c4f 
…1123)
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
feat: add quantity error message on the PDP when adding to the cart (#…
66f9f07 
…1123)
Frodigo pushed a commit that referenced this pull request Jul 4, 2022
@bartoszherba
feat: add quantity error message on the PDP when adding to the cart (#…
eeca478 
…1123)
This was referenced Jul 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden Awaiting requested review from sethidden

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.10

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo