Skip to content

fix!: checkout province state code issue #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix!: checkout province state code issue #1120

merged 1 commit into from
Jun 13, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 13, 2022 •
edited
Loading

Description

  • province/state will be now properly displayed on the shipping and billing steps

Related Issue

#1003

How Has This Been Tested?

  1. Add any product to cart.
  2. Open cart.
  3. Hit Go to Checkout button.
  4. Add shipping data.
  5. Select Shipping Method.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-588-checkout-province-state-code-instead-of-province-state-name-in-billing branch from 575a858 to 703213b Compare June 13, 2022 08:31
@Frodigo Frodigo changed the title fix: checkout province state code issue fix!: checkout province state code issue Jun 13, 2022
Frodigo
Frodigo previously approved these changes Jun 13, 2022
View reviewed changes
@bartoszherba
fix: checkout province state code issue
b786b3e 
- province/state will be now properly displayed on the shipping and billing steps
@bartoszherba bartoszherba force-pushed the M2-588-checkout-province-state-code-instead-of-province-state-name-in-billing branch from 703213b to b786b3e Compare June 13, 2022 11:59
@Frodigo Frodigo merged commit 064ca8d into develop Jun 13, 2022
@Frodigo Frodigo deleted the M2-588-checkout-province-state-code-instead-of-province-state-name-in-billing branch June 13, 2022 12:12
@Frodigo Frodigo added this to the 1.0.0-rc.10 milestone Jun 13, 2022
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
fix: checkout province state code issue (#1120)
d3e6b6b 
- province/state will be now properly displayed on the shipping and billing steps
Frodigo pushed a commit that referenced this pull request Jun 22, 2022
@bartoszherba
fix: checkout province state code issue (#1120)
41f3b48 
- province/state will be now properly displayed on the shipping and billing steps
Frodigo pushed a commit that referenced this pull request Jul 4, 2022
@bartoszherba
fix: checkout province state code issue (#1120)
b4b5162 
- province/state will be now properly displayed on the shipping and billing steps
This was referenced Jul 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden Awaiting requested review from sethidden

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.10

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo