Coupon code input box should show error message when an invalid coupon code is entered

[sync-by-unito]

Currently when you input a coupon code during checkout, if you input a wrong one (ie. one that is not valid, one that doesn’t exist within Magento), there isn’t any error message to let the user know that an error occurred. Also, sending any promo code sends an error in the console about “promoIsApplied” being a of String type, while it’s expected to be Boolean.

You can also test the case of a correct promo code by using “vsf2022” promo code - it exists within the dev Magento instance

┆Attachments: image-20220517-070634.png | image-20220517-070719.png

[sync-by-unito]

➤ Bartosz Herba commented:

Gabriel Golla Please, verify on the dev env.

[sync-by-unito]

➤ Gabriel Golla commented:

OK, verified and confirmed on DEN env that error message is displayed (both EN and DE) and there is no error in the console about “promoIsApplied” being a of String type, while it’s expected to be Boolean.

Instead I see following TypeError in the console - dunno if it’s on purpose, cc. Bartosz Herba .

[VSF][error]: useCart/applyCoupon TypeError: Cannot read properties of null (reading 'cart')
at Object. (applyCouponCommand.ts:24:43)
at Generator.next ()
at r (asyncToGenerator.js:3:20)
at l (asyncToGenerator.js:25:9)Verified using following browsers:

1. Chrome desktop (101) and mobile (101)
2. Safari desktop (15.4) and mobile (15.4)
3. Edge desktop (101) and mobile (100)
4. Firefox desktop (100) and mobile (99)
5. Opera desktop (86) and mobile (69)

Regarding error message IMO we have to change it later to something more specific cc. Milosh Belter .

[sync-by-unito]

➤ Bartosz Herba commented:

Ye, ok, this is something that must be fixed too, along with the message. Magento returns the proper message and we can use it and display it. “An error occurred” is cool but not for humans 😉

cc: Milosh Belter Marcin Kwiatkowski

[sync-by-unito]

➤ Artur Tagisow commented:

I agree the current error message is too generic - I just wanted to improve over the previous behavior of “nothing is shown at all” without adding new translations.

The error is indeed sent out, but Bartosz Herba just mentioned that this error message is not sent accessible through the composable (in the errors object)

!image-20220517-070634.png|width=438,height=129!

(fyi the error message is not localized if it occurrs on the german instace. We spoke of this behavior during last grooming, but just throwing it out there to make sure everyone is on the same page)

!image-20220517-070719.png|width=847,height=914!

[sync-by-unito]

➤ Bartosz Herba commented:

#1009 ( https://github.com/vuestorefront/magento2/pull/1009|smart-link )

[sync-by-unito]

➤ Bartosz Herba commented:

Gabriel Golla Please, verify on the dev env.

[sync-by-unito]

➤ Gabriel Golla commented:

Ok, error message displayed in case of using wrong promo code now makes more sense than “An error occurred” 😉

I still see error in the console:

VSF][error]: useCart/applyCoupon