Skip to content

feat(plugin-git): remove duplicate no-reply contributors #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2023
Merged

feat(plugin-git): remove duplicate no-reply contributors #1364

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da1369e
feat(plugin-git): remove duplicate no-reply contributors
lukemassa Jun 18, 2023
b40a014
Update getContributors.ts
meteorlxy Jul 6, 2023
04ac7b0
Update getContributors.ts
meteorlxy Jul 6, 2023
aa5d24c
feat(plugin-git): merge contribution numbers for duplicates
lukemassa Jul 8, 2023
c38f703
Update getContributors.ts
meteorlxy Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ecosystem/plugin-git/src/node/utils/getContributors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,19 @@ export const getContributors = async (
email,
commits: Number.parseInt(commits, 10),
}))
.filter((item, index, self) => {
// If one of the contributors is a "noreply" email address, and there's
// already a contributor with the same name, it is very likely a duplicate,
// so it can be removed.
if (item.email.split('@')[1]?.match(/no-?reply/)) {
const realIndex = self.findIndex((t) => t.name === item.name)
if (realIndex !== index) {
// Update the "real" contributor to also include the noreply's commits
self[realIndex].commits += item.commits
return false
}
return true
}
return true
})
}