Skip to content

Conversation

@hong4rc
Copy link
Contributor

@hong4rc hong4rc commented Jan 3, 2021

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

  • return true if a route match instead of filter all and check length
  • store path.toLowerCase() to pathLower (don't call each route)

@billyyyyy3320 billyyyyy3320 changed the title refactor: use some instead of filter refactor: use some instead of filter when checking route existence Feb 15, 2021
@billyyyyy3320 billyyyyy3320 changed the title refactor: use some instead of filter when checking route existence refactor($core): use some instead of filter when checking route existence Feb 15, 2021
@billyyyyy3320 billyyyyy3320 merged commit 1aceca1 into vuejs:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants