Skip to content

Conversation

@ycmjason
Copy link
Contributor

No description provided.

@mdaffin
Copy link
Contributor

mdaffin commented Apr 23, 2018

Should the .firebaserc and firebase.json files not exist at the project root level? With "public": "docs/.vuepress/dist", (or where your actual dist exists) in the firebase.json? Then there is no need for a wrapper script and firebase deploy can be added to the package.json's script section directly.

@ycmjason
Copy link
Contributor Author

Good idea! Will change this now! 🥂

@ycmjason
Copy link
Contributor Author

@mdaffin I have updated the guide, do you want to review this again please?

@mdaffin
Copy link
Contributor

mdaffin commented Apr 23, 2018

Much better, though I think you should use docs/.vuepress/dist to keep it consistent with the netlify instructions. Then I think you also don't require the ignore part as everything in dist should be included?

@ycmjason
Copy link
Contributor Author

@mdaffin
Yeah you are right. I have also fixed github pages script for not using docs/.vuepress/dist.

@yyx990803 yyx990803 merged commit 5a175c3 into vuejs:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants