Allowing config option to set which headers to extract #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Contributor
Author
Contributor
Author
ulivz
requested changes
Jan 15, 2019
| if (siteConfig.markdown && siteConfig.markdown.extractHeaders) { | ||
| headersToExtract = siteConfig.markdown.extractHeaders | ||
| } | ||
| const headers = extractHeaders(content, headersToExtract, markdown) |
Member
There was a problem hiding this comment.
I remember I have said that siteConfig shouldn't be passed to markdown-loader like a giant brick
Contributor
Author
There was a problem hiding this comment.
Should I just change this to pass in siteConfig.markdown instead of all of siteConfig?
Contributor
Author
|
@ulivz I think this is what you are talking about now |
ulivz
force-pushed
the
master
branch
5 times, most recently
from
316e022 to
1284944
Compare
This was referenced Jul 28, 2019
Closed
flozero
added
complexity: medium
Collaborator
|
We should take care about the search too with that to be sure all is working well |
Collaborator
|
Hello i'm closing this PR as it's now replace by this one #1730 Thank's for your work all ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #984
This PR replaces #1004
Currently the header parsing is hard coded to
['h2', 'h3']. This code changes that to give the ability to configure this in thethemeOptionsconfig.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: