Skip to content

[vue-server-renderer] ensure assets are unique #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2017
+10 −4
Merged

[vue-server-renderer] ensure assets are unique #5540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acc89d
[vue-server-renderer] ensure assets are unique
Apr 28, 2017
1ea8bc9
add lodash.uniq to devDependencies
Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
"karma-webpack": "^2.0.1",
"lodash": "^4.17.1",
"lodash.template": "^4.4.0",
"lodash.uniq": "^4.5.0",
"lru-cache": "^4.0.2",
"nightwatch": "^0.9.9",
"nightwatch-helpers": "^1.2.0",
Expand Down
1 change: 1 addition & 0 deletions packages/vue-server-renderer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"hash-sum": "^1.0.2",
"he": "^1.1.0",
"lodash.template": "^4.4.0",
"lodash.uniq": "^4.5.0",
"resolve": "^1.2.0",
"source-map": "0.5.6",
"serialize-javascript": "^1.3.0"
Expand Down
12 changes: 8 additions & 4 deletions src/server/webpack-plugin/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const hash = require('hash-sum')
const uniq = require('lodash.uniq')
import { isJS } from './util'

export default class VueSSRClientPlugin {
Expand All @@ -12,13 +13,13 @@ export default class VueSSRClientPlugin {
compiler.plugin('emit', (compilation, cb) => {
const stats = compilation.getStats().toJson()

const allFiles = stats.assets
.map(a => a.name)
const allFiles = uniq(stats.assets
.map(a => a.name))

const initialFiles = Object.keys(stats.entrypoints)
const initialFiles = uniq(Object.keys(stats.entrypoints)
.map(name => stats.entrypoints[name].assets)
.reduce((assets, all) => all.concat(assets), [])
.filter(isJS)
.filter(isJS))

const asyncFiles = allFiles
.filter(isJS)
Expand All @@ -39,6 +40,9 @@ export default class VueSSRClientPlugin {
if (m.chunks.length === 1) {
const cid = m.chunks[0]
const chunk = stats.chunks.find(c => c.id === cid)
if (!chunk || !chunk.files) {
return
}
const files = manifest.modules[hash(m.identifier)] = chunk.files.map(fileToIndex)
// find all asset modules associated with the same chunk
assetModules.forEach(m => {
Expand Down