Skip to content

Check property exists instead of truthy value #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2017
Merged

Check property exists instead of truthy value #5044

merged 2 commits into from
Mar 1, 2017

Conversation

znck
Copy link
Member

@znck znck commented Mar 1, 2017

Fixes #5043

posva
posva reviewed Mar 1, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should improve the test at f916bcf#diff-bca44b08ed9d6769ecba792a55356445R17 😛

@znck
Copy link
Member Author

znck commented Mar 1, 2017

/ping @yyx990803

@yyx990803 yyx990803 merged commit 2a8a777 into vuejs:dev Mar 1, 2017
@znck znck deleted the znck-patch-1 branch March 1, 2017 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

+1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@znck @kazupon @posva @yyx990803