Skip to content

fixed Vue.delete(vm, key) #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2016
Merged

fixed Vue.delete(vm, key) #2731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35905ff
fixed Vue.delete(vm, key) bug
Jinjiang Apr 26, 2016
62b5b9b
rollback to es5 syntax in test case
Jinjiang Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/util/lang.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export function del (obj, key) {
delete obj[key]
var ob = obj.__ob__
if (!ob) {
if (obj._isVue) {
delete obj._data[key]
obj._digest()
}
return
}
ob.dep.notify()
Expand Down
19 changes: 19 additions & 0 deletions test/unit/specs/observer/observer_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,25 @@ describe('Observer', function () {
expect(dep3.notify.calls.count()).toBe(2)
})

it('observing set/delete in Vm object', function (done) {
var el = document.createElement('div')
var vm = new Vue({
el: el,
template: '<div>{{a}}</div>',
data: { a: 1 }
})
expect(el.innerHTML).toBe('<div>1</div>')
Vue.set(vm, 'a', 2)
Vue.nextTick(function () {
expect(el.innerHTML).toBe('<div>2</div>')
Vue.delete(vm, 'a')
Vue.nextTick(function () {
expect(el.innerHTML).toBe('<div></div>')
done()
})
})
})

it('observing array mutation', function () {
var arr = []
var ob = observe(arr)
Expand Down