use absolute exclude path in build/webpack.test.config.js and fix error when recursively traverse an object
#2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2016 09:17
flytreeleft
changed the title
build/webpack.test.config.jsbuild/webpack.test.config.js and fix 'Maximum call stack size exceeded' when recursively traverse an object
flytreeleft
changed the title
build/webpack.test.config.js and fix 'Maximum call stack size exceeded' when recursively traverse an objectbuild/webpack.test.config.js and fix error when recursively traverse an object
src/watcher.js
Outdated
| function traverse (val, walkedObjs) { | ||
| var i, keys | ||
|
|
||
| !walkedObjs && (walkedObjs = {}) |
There was a problem hiding this comment.
I'm curious about this notation. How is it different from walkedObjs = walkedObjs || {} ?
There was a problem hiding this comment.
Uh, it's just personal habits, there is no difference between them, do not be feeling trouble with it.
There was a problem hiding this comment.
I wasn't complaining, just curious 😄
|
Please do not mix multiple fixes in the same PR, since this makes it harder to review and merge. Submit separate PRs please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.