Skip to content

fix: fix(ssr) textarea domProps keeps falsy values (#10803) #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+21 −1
Closed

fix: fix(ssr) textarea domProps keeps falsy values (#10803) #11102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platforms/web/server/modules/dom-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default function renderDOMProps (node: VNodeWithData): string {
setText(node, props[key], true)
} else if (key === 'textContent') {
setText(node, props[key], false)
} else if (key === 'value' && node.tag === 'textarea') {
} else if (props[key] && key === 'value' && node.tag === 'textarea') {
setText(node, props[key], false)
} else {
// $flow-disable-line (WTF?)
Expand Down
20 changes: 20 additions & 0 deletions test/ssr/ssr-string.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,26 @@ describe('SSR: renderToString', () => {
})
})

// SSR: textarea domProps keeps falsy values #10803
it('falsy domProps value', done => {
renderVmWithOptions({
render(h) {
return h('div', [
h('textarea', {
domProps: {
value: null
}
})
])
}
}, result => {
expect(result).toContain(
'<div data-server-rendered="true"><textarea></textarea></div>'
)
done()
})
})

it('render v-model with <select> (value binding)', done => {
renderVmWithOptions({
data: {
Expand Down