Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

refactor: component slots #238

Merged
merged 10 commits into from
Jun 18, 2024
Merged

refactor: component slots #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3b01af
refactor: component slots
sxzz Jun 17, 2024
da519f3
fix: optimized static slots
sxzz Jun 18, 2024
7abaa92
refactor: remove array of dynamic slots
sxzz Jun 18, 2024
e0ba0ff
refactor(runtime/compiler-vapor): refactor slots
Doctor-wu Jun 18, 2024
05941b8
test(runtime-vapor): add createForSlots test case
Doctor-wu Jun 18, 2024
41f6ae2
refactor: format
sxzz Jun 18, 2024
78463fc
refactor: static slots
sxzz Jun 18, 2024
148880a
refactor
sxzz Jun 18, 2024
cdd9025
chore: remove todo
sxzz Jun 18, 2024
5f3d8bf
fix unit tests
sxzz Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,20 @@ export function render(_ctx) {
const _component_Comp = _resolveComponent("Comp")
const _directive_hello = _resolveDirective("hello")
const _directive_test = _resolveDirective("test")
const n4 = _createComponent(_component_Comp, null, { default: () => {
const n0 = _createIf(() => (true), () => {
const n3 = t0()
const n2 = _createComponent(_component_Bar)
_withDirectives(n2, [[_directive_hello, void 0, void 0, { world: true }]])
_insert(n2, n3)
return n3
})
return n0
} }, null, true)
const n4 = _createComponent(_component_Comp, null, [
{
default: () => {
const n0 = _createIf(() => (true), () => {
const n3 = t0()
const n2 = _createComponent(_component_Bar)
_withDirectives(n2, [[_directive_hello, void 0, void 0, { world: true }]])
_insert(n2, n3)
return n3
})
return n0
}
}
], true)
_withDirectives(n4, [[_directive_test]])
return n4
}"
Expand Down
38 changes: 19 additions & 19 deletions packages/compiler-vapor/__tests__/transforms/__snapshots__/transformElement.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`compiler: element transform > component > do not resolve component from

export function render(_ctx) {
const _component_Example = _resolveComponent("Example")
const n0 = _createComponent(_component_Example, null, null, null, true)
const n0 = _createComponent(_component_Example, null, null, true)
return n0
}"
`;
Expand All @@ -25,7 +25,7 @@ exports[`compiler: element transform > component > generate single root componen
"import { createComponent as _createComponent } from 'vue/vapor';

export function render(_ctx) {
const n0 = _createComponent(_ctx.Comp, null, null, null, true)
const n0 = _createComponent(_ctx.Comp, null, null, true)
return n0
}"
`;
Expand All @@ -35,21 +35,21 @@ exports[`compiler: element transform > component > import + resolve component 1`

export function render(_ctx) {
const _component_Foo = _resolveComponent("Foo")
const n0 = _createComponent(_component_Foo, null, null, null, true)
const n0 = _createComponent(_component_Foo, null, null, true)
return n0
}"
`;

exports[`compiler: element transform > component > resolve component from setup bindings (inline const) 1`] = `
"(() => {
const n0 = _createComponent(Example, null, null, null, true)
const n0 = _createComponent(Example, null, null, true)
return n0
})()"
`;

exports[`compiler: element transform > component > resolve component from setup bindings (inline) 1`] = `
"(() => {
const n0 = _createComponent(_unref(Example), null, null, null, true)
const n0 = _createComponent(_unref(Example), null, null, true)
return n0
})()"
`;
Expand All @@ -58,14 +58,14 @@ exports[`compiler: element transform > component > resolve component from setup
"import { createComponent as _createComponent } from 'vue/vapor';

export function render(_ctx) {
const n0 = _createComponent(_ctx.Example, null, null, null, true)
const n0 = _createComponent(_ctx.Example, null, null, true)
return n0
}"
`;

exports[`compiler: element transform > component > resolve namespaced component from props bindings (inline) 1`] = `
"(() => {
const n0 = _createComponent(Foo.Example, null, null, null, true)
const n0 = _createComponent(Foo.Example, null, null, true)
return n0
})()"
`;
Expand All @@ -74,14 +74,14 @@ exports[`compiler: element transform > component > resolve namespaced component
"import { createComponent as _createComponent } from 'vue/vapor';

export function render(_ctx) {
const n0 = _createComponent(_ctx.Foo.Example, null, null, null, true)
const n0 = _createComponent(_ctx.Foo.Example, null, null, true)
return n0
}"
`;

exports[`compiler: element transform > component > resolve namespaced component from setup bindings (inline const) 1`] = `
"(() => {
const n0 = _createComponent(Foo.Example, null, null, null, true)
const n0 = _createComponent(Foo.Example, null, null, true)
return n0
})()"
`;
Expand All @@ -90,7 +90,7 @@ exports[`compiler: element transform > component > resolve namespaced component
"import { createComponent as _createComponent } from 'vue/vapor';

export function render(_ctx) {
const n0 = _createComponent(_ctx.Foo.Example, null, null, null, true)
const n0 = _createComponent(_ctx.Foo.Example, null, null, true)
return n0
}"
`;
Expand All @@ -102,7 +102,7 @@ export function render(_ctx) {
const _component_Foo = _resolveComponent("Foo")
const n0 = _createComponent(_component_Foo, [
{ onBar: () => $event => (_ctx.handleBar($event)) }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -117,7 +117,7 @@ export function render(_ctx) {
id: () => ("foo"),
class: () => ("bar")
}
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -129,7 +129,7 @@ export function render(_ctx) {
const _component_Foo = _resolveComponent("Foo")
const n0 = _createComponent(_component_Foo, [
() => (_ctx.obj)
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -142,7 +142,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Foo, [
{ id: () => ("foo") },
() => (_ctx.obj)
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -155,7 +155,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Foo, [
() => (_ctx.obj),
{ id: () => ("foo") }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -169,7 +169,7 @@ export function render(_ctx) {
{ id: () => ("foo") },
() => (_ctx.obj),
{ class: () => ("bar") }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -181,7 +181,7 @@ export function render(_ctx) {
const _component_Foo = _resolveComponent("Foo")
const n0 = _createComponent(_component_Foo, [
() => (_toHandlers(_ctx.obj))
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -195,7 +195,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Foo, [
() => ({ [_toHandlerKey(_ctx.foo-_ctx.bar)]: () => _ctx.bar }),
() => ({ [_toHandlerKey(_ctx.baz)]: () => _ctx.qux })
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -208,7 +208,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Foo, [
() => ({ [_ctx.foo-_ctx.bar]: _ctx.bar }),
() => ({ [_ctx.baz]: _ctx.qux })
], null, null, true)
], null, true)
return n0
}"
`;
Expand Down
12 changes: 6 additions & 6 deletions packages/compiler-vapor/__tests__/transforms/__snapshots__/vModel.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export function render(_ctx) {
{ modelValue: () => (_ctx.foo),
"onUpdate:modelValue": () => $event => (_ctx.foo = $event),
modelModifiers: () => ({ trim: true, "bar-baz": true }) }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -22,7 +22,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Comp, [
{ modelValue: () => (_ctx.foo),
"onUpdate:modelValue": () => $event => (_ctx.foo = $event) }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -41,7 +41,7 @@ export function render(_ctx) {
"onUpdate:bar": () => $event => (_ctx.bar = $event),
barModifiers: () => ({ number: true })
}
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -54,7 +54,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Comp, [
{ bar: () => (_ctx.foo),
"onUpdate:bar": () => $event => (_ctx.foo = $event) }
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -71,7 +71,7 @@ export function render(_ctx) {
() => ({ [_ctx.bar]: _ctx.bar,
["onUpdate:" + _ctx.bar]: () => $event => (_ctx.bar = $event),
[_ctx.bar + "Modifiers"]: () => ({ number: true }) })
], null, null, true)
], null, true)
return n0
}"
`;
Expand All @@ -84,7 +84,7 @@ export function render(_ctx) {
const n0 = _createComponent(_component_Comp, [
() => ({ [_ctx.arg]: _ctx.foo,
["onUpdate:" + _ctx.arg]: () => $event => (_ctx.foo = $event) })
], null, null, true)
], null, true)
return n0
}"
`;
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-vapor/__tests__/transforms/__snapshots__/vOnce.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function render(_ctx) {
const n1 = t0()
const n0 = _createComponent(_component_Comp, [
{ id: () => (_ctx.foo) }
], null, null, null, true)
], null, null, true)
_insert(n0, n1)
return n1
}"
Expand Down
Loading