Skip to content

Respect "hidden" attributes when testing Wrapper.isVisible() #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Respect "hidden" attributes when testing Wrapper.isVisible() #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad23e0
Respect "hidden" attributes when testing Wrapper.isVisible()
stevegrunwell Jun 11, 2019
2833055
Update coding standards per Prettier
stevegrunwell Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/test-utils/src/wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,10 @@ export default class Wrapper implements BaseWrapper {
let element = this.element
while (element) {
if (
element.style &&
(element.style.visibility === 'hidden' ||
element.style.display === 'none')
element.hidden ||
(element.style &&
(element.style.visibility === 'hidden' ||
element.style.display === 'none'))
) {
return false
}
Expand Down
9 changes: 9 additions & 0 deletions test/specs/wrapper/isVisible.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ describeWithShallowAndMount('isVisible', mountingMethod => {
expect(element.isVisible()).to.equal(false)
})

it('returns false if element has hidden attribute', () => {
const compiled = compileToFunctions(
'<div><div><span class="visible" hidden></span></div></div>'
)
const wrapper = mountingMethod(compiled)
const element = wrapper.find('.visible')
expect(element.isVisible()).to.equal(false)
})

it('returns true if element has v-show true', async () => {
const wrapper = mountingMethod(ComponentWithVShow)
wrapper.vm.$set(wrapper.vm, 'ready', true)
Expand Down