Skip to content

Conversation

alphawq
Copy link
Contributor

@alphawq alphawq commented Jun 16, 2021

No description provided.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a reproduction or a failing test (before the change)?

@alphawq
Copy link
Contributor Author

alphawq commented Jun 16, 2021

Can you provide a reproduction or a failing test (before the change)?

It's not exactly a bug, but if parent.alias does not exist, there is no need to execute createRouteMap

@posva posva changed the title fix(addRoute): create route only when parent.alias exists refactor(addRoute): create route only when parent.alias exists Jun 16, 2021
…ty array


if parent.alias is an empty array, there is no need to execute createRouteMap

Co-authored-by: Eduardo San Martin Morote <[email protected]>
@posva posva merged commit 9a0b9fb into vuejs:dev Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants