Skip to content

fix(TS): update type of Route.name #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2020
Merged

fix(TS): update type of Route.name #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e2cb6
Update type of Route.name
rijkvanzanten Feb 6, 2020
252a368
fix(tests): fix type test
rijkvanzanten Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/router.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export interface Location {

export interface Route {
path: string
name?: string
name?: string | null
hash: string
query: Dictionary<string | (string | null)[]>
params: Dictionary<string>
Expand Down
4 changes: 2 additions & 2 deletions types/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const mode: string = router.mode

const route: Route = router.currentRoute
const path: string = route.path
const name: string | undefined = route.name
const name: string | undefined | null = route.name
const hash: string = route.hash
const query: string | (string | null)[] | null = route.query['foo']
const params: string = route.params['bar']
Expand All @@ -128,7 +128,7 @@ matched.forEach(m => {
[key: string]: ComponentOptions<Vue> | typeof Vue | AsyncComponent
} = m.components
const instances: { [key: string]: Vue } = m.instances
const name: string | undefined = m.name
const name: string | undefined | null = m.name
const parant: RouteRecord | undefined = m.parent
const redirect: RedirectOption | undefined = m.redirect
})
Expand Down