Skip to content

Fix active class priority #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Fix active class priority #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/components/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ export default {
exact: Boolean,
append: Boolean,
replace: Boolean,
activeClass: {
type: String,
default: 'router-link-active'
},
activeClass: String,
event: {
type: eventTypes,
default: 'click'
Expand All @@ -37,9 +34,13 @@ export default {

const classes = {}
const globalActiveClass = router.options.linkActiveClass
const activeClass = globalActiveClass == null
? this.activeClass
: globalActiveClass
// Support global empty active class
const activeClassFallback = globalActiveClass == null
? 'router-link-active'
: globalActiveClass
const activeClass = this.activeClass == null
? activeClassFallback
: this.activeClass
const compareTarget = location.path
? createRoute(null, location, null, router)
: route
Expand Down