Skip to content

Add note about $router in navigation #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2017
Merged

Add note about $router in navigation #1304

merged 2 commits into from
Apr 6, 2017

Conversation

@posva
Copy link
Member

@posva posva commented Apr 4, 2017

Closes #1136

@posva posva requested a review from fnlctrl April 5, 2017 21:54
@posva
Copy link
Member Author

posva commented Apr 5, 2017

Thanks @kazupon !
It's so cool you always review many PR 🙂

@yyx990803 yyx990803 merged commit e768e4a into dev Apr 6, 2017
kazupon added a commit to kazupon/vue-router that referenced this pull request Apr 8, 2017
@kazupon
pick up from vuejs#1304
c6f8b8e
kazupon added a commit that referenced this pull request Apr 10, 2017
@kazupon
Translation ja docs (#1317)
3f5b6f1 
* pick up translation from #1252

* pick up translation from #1307

* translation

* pick up from #1304

* translate previous commit

* pick up from 9b7f766

* translate previous commit

* fix translation
@posva posva deleted the router-note branch April 14, 2017 17:05
@posva posva mentioned this pull request Apr 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fnlctrl fnlctrl Awaiting requested review from fnlctrl

1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@posva @kazupon @yyx990803