Skip to content

Add base in abstract mode (fix #983) #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Add base in abstract mode (fix #983) #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0f036
Add base in abstract mode
atinux Dec 22, 2016
5dbb1b3
Abtract mode give base in 2nd argument
atinux Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/history/abstract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export class AbstractHistory extends History {
index: number;
stack: Array<Route>;

constructor (router: VueRouter) {
super(router)
constructor (router: VueRouter, base: ?string) {
super(router, base)
this.stack = []
this.index = -1
}
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class VueRouter {
this.history = new HashHistory(this, options.base, this.fallback)
break
case 'abstract':
this.history = new AbstractHistory(this)
this.history = new AbstractHistory(this, options.base)
break
default:
process.env.NODE_ENV !== 'production' && assert(false, `invalid mode: ${mode}`)
Expand Down