Skip to content

fix(cli-service): don't write entry-wc to node_modules #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

fix(cli-service): don't write entry-wc to node_modules #6101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ template
template-vue3
packages/test
temp
entry-wc.js
dist
__testfixtures__
1 change: 0 additions & 1 deletion packages/@vue/cli-service/lib/commands/build/.gitignore
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion packages/@vue/cli-service/lib/commands/build/resolveWcConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ module.exports = (api, { target, entry, name, 'inline-vue': inlineVue }) => {
config.optimization.minimize(false)
}

config
.plugin('webpack-virtual-modules')
.use(require('webpack-virtual-modules'), [{
[dynamicEntry.filePath]: dynamicEntry.content
}])

config
.plugin('web-component-options')
.use(require('webpack').DefinePlugin, [{
Expand Down Expand Up @@ -108,7 +114,7 @@ module.exports = (api, { target, entry, name, 'inline-vue': inlineVue }) => {

const entryName = `${libName}${minify ? `.min` : ``}`
rawConfig.entry = {
[entryName]: dynamicEntry
[entryName]: dynamicEntry.filePath
}

Object.assign(rawConfig.output, {
Expand Down
8 changes: 5 additions & 3 deletions packages/@vue/cli-service/lib/commands/build/resolveWcEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const fs = require('fs')
const path = require('path')

const camelizeRE = /-(\w)/g
Expand Down Expand Up @@ -56,6 +55,9 @@ import 'vue-style-loader/lib/addStylesShadow'
import 'vue-loader/lib/runtime/componentNormalizer'

${elements}`.trim()
fs.writeFileSync(filePath, content)
return filePath

return {
filePath: filePath,
content: content
}
}
3 changes: 2 additions & 1 deletion packages/@vue/cli-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@
"webpack-bundle-analyzer": "^3.8.0",
"webpack-chain": "^6.4.0",
"webpack-dev-server": "^3.11.0",
"webpack-merge": "^4.2.2"
"webpack-merge": "^4.2.2",
"webpack-virtual-modules": "^0.4.1"
},
"peerDependencies": {
"@vue/compiler-sfc": "^3.0.0-beta.14",
Expand Down
98 changes: 92 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3385,6 +3385,87 @@
"@vue/babel-plugin-transform-vue-jsx" "^1.2.1"
camelcase "^5.0.0"

"@vue/cli-plugin-babel@file:packages/@vue/cli-plugin-babel":
version "4.5.8"
dependencies:
"@babel/core" "^7.11.6"
"@vue/babel-preset-app" "^4.5.8"
"@vue/cli-shared-utils" "^4.5.8"
babel-loader "^8.1.0"
cache-loader "^4.1.0"
thread-loader "^3.0.0"
webpack "^4.0.0"

"@vue/cli-plugin-unit-mocha@file:packages/@vue/cli-plugin-unit-mocha":
version "4.5.8"
dependencies:
"@vue/cli-shared-utils" "^4.5.8"
jsdom "^16.4.0"
jsdom-global "^3.0.2"
mocha "^7.2.0"
mochapack "^2.0.2"

"@vue/cli-service@file:packages/@vue/cli-service":
version "4.5.8"
dependencies:
"@intervolga/optimize-cssnano-plugin" "^1.0.5"
"@soda/friendly-errors-webpack-plugin" "^1.7.1"
"@soda/get-current-script" "^1.0.0"
"@types/minimist" "^1.2.0"
"@types/webpack" "^4.0.0"
"@types/webpack-dev-server" "^3.11.0"
"@vue/cli-overlay" "^4.5.8"
"@vue/cli-plugin-router" "^4.5.8"
"@vue/cli-plugin-vuex" "^4.5.8"
"@vue/cli-shared-utils" "^4.5.8"
"@vue/component-compiler-utils" "^3.1.2"
"@vue/preload-webpack-plugin" "^1.1.0"
"@vue/web-component-wrapper" "^1.2.0"
acorn "^8.0.1"
acorn-walk "^8.0.0"
address "^1.1.2"
autoprefixer "^9.8.6"
browserslist "^4.14.1"
cache-loader "^4.1.0"
case-sensitive-paths-webpack-plugin "^2.3.0"
cli-highlight "^2.1.4"
clipboardy "^2.3.0"
cliui "^6.0.0"
copy-webpack-plugin "^6.2.1"
css-loader "^3.5.3"
cssnano "^4.1.10"
debug "^4.1.1"
default-gateway "^6.0.2"
dotenv "^8.2.0"
dotenv-expand "^5.1.0"
file-loader "^6.1.1"
fs-extra "^7.0.1"
globby "^9.2.0"
hash-sum "^2.0.0"
html-webpack-plugin "^3.2.0"
launch-editor-middleware "^2.2.1"
lodash.defaultsdeep "^4.6.1"
lodash.mapvalues "^4.6.0"
lodash.transform "^4.6.0"
mini-css-extract-plugin "^0.9.0"
minimist "^1.2.5"
pnp-webpack-plugin "^1.6.4"
portfinder "^1.0.26"
postcss-loader "^3.0.0"
ssri "^8.0.0"
terser-webpack-plugin "^4.2.3"
thread-loader "^3.0.0"
url-loader "^4.1.1"
vue-loader "^15.9.2"
vue-loader-v16 "npm:vue-loader@^16.1.0"
vue-style-loader "^4.1.2"
webpack "^4.0.0"
webpack-bundle-analyzer "^3.8.0"
webpack-chain "^6.4.0"
webpack-dev-server "^3.11.0"
webpack-merge "^4.2.2"
webpack-virtual-modules "^0.4.1"

"@vue/[email protected]":
version "3.0.2"
resolved "https://registry.yarnpkg.com/@vue/compiler-core/-/compiler-core-3.0.2.tgz#7790b7a1fcbba5ace4d81a70ce59096fa5c95734"
Expand Down Expand Up @@ -20481,10 +20562,10 @@ vue-jest@^3.0.5:
tsconfig "^7.0.0"
vue-template-es2015-compiler "^1.6.0"

"vue-loader-v16@npm:vue-loader@^16.0.0-beta.7":
version "16.0.0-rc.2"
resolved "https://registry.yarnpkg.com/vue-loader/-/vue-loader-16.0.0-rc.2.tgz#b6a7e7f30d28f35659a83de41f4a1831a4232a04"
integrity sha512-cz8GK4dgIf1UTC+do80pGvh8BHcCRHLIQVHV9ONVQ8wtoqS9t/+H02rKcQP+TVNg7khgLyQV2+8eHUq7/AFq3g==
"vue-loader-v16@npm:vue-loader@^16.1.0":
version "16.1.0"
resolved "https://registry.yarnpkg.com/vue-loader/-/vue-loader-16.1.0.tgz#e4544abf65cbb3b81f3d5360d95a3e2ae83749a1"
integrity sha512-fTtCdI7VeyNK0HP4q4y9Z9ts8TUeaF+2/FjKx8CJ/7/Oem1rCX7zIJe+d+jLrVnVNQjENd3gqmANraLcdRWwnQ==
dependencies:
chalk "^4.1.0"
hash-sum "^2.0.0"
Expand Down Expand Up @@ -20560,7 +20641,7 @@ vue-style-loader@^4.1.0, vue-style-loader@^4.1.2:
hash-sum "^1.0.2"
loader-utils "^1.0.2"

vue-template-compiler@^2.6.10, vue-template-compiler@^2.6.12:
vue-template-compiler@^2.6.10, vue-template-compiler@^2.6.11, vue-template-compiler@^2.6.12:
version "2.6.12"
resolved "https://registry.yarnpkg.com/vue-template-compiler/-/vue-template-compiler-2.6.12.tgz#947ed7196744c8a5285ebe1233fe960437fcc57e"
integrity sha512-OzzZ52zS41YUbkCBfdXShQTe69j1gQDZ9HIX8miuC9C3rBCk9wIRjLiZZLrmX9V+Ftq/YEyv1JaVr5Y/hNtByg==
Expand Down Expand Up @@ -20589,7 +20670,7 @@ vue-virtual-scroller@^1.0.10:
vue-observe-visibility "^0.4.4"
vue-resize "^0.4.5"

vue@^2.6.10, vue@^2.6.12:
vue@^2.6.10, vue@^2.6.11, vue@^2.6.12:
version "2.6.12"
resolved "https://registry.yarnpkg.com/vue/-/vue-2.6.12.tgz#f5ebd4fa6bd2869403e29a896aed4904456c9123"
integrity sha512-uhmLFETqPPNyuLLbsKz6ioJ4q7AZHzD8ZVFNATNyICSZouqP2Sz0rotWQC8UNBF6VGSCs5abnKJoStA6JbCbfg==
Expand Down Expand Up @@ -20920,6 +21001,11 @@ webpack-sources@^1.1.0, webpack-sources@^1.4.0, webpack-sources@^1.4.1, webpack-
source-list-map "^2.0.0"
source-map "~0.6.1"

webpack-virtual-modules@^0.4.1:
version "0.4.1"
resolved "https://registry.yarnpkg.com/webpack-virtual-modules/-/webpack-virtual-modules-0.4.1.tgz#cae5a7085d34331d077225f77037bea233dbfdad"
integrity sha512-BH/RKOHk223WdBDLFqghztx3DF5AqR3CKg3ue1KN9S1SAaXP68Kj/4rF0lsdysxXaanzx7aWl1u0+lnfj7+OtQ==

webpack@^4.0.0, webpack@^4.8.1:
version "4.44.2"
resolved "https://registry.yarnpkg.com/webpack/-/webpack-4.44.2.tgz#6bfe2b0af055c8b2d1e90ed2cd9363f841266b72"
Expand Down