Skip to content

fix: only replace App.vue when there's no router plugin #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

fix: only replace App.vue when there's no router plugin #5771

merged 1 commit into from
Aug 11, 2020

Conversation

haoqunjiang
Copy link
Member

Fixes #5770

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang haoqunjiang merged commit 2a56179 into vuejs:dev Aug 11, 2020
@haoqunjiang haoqunjiang deleted the fix-ts-router-template branch August 11, 2020 08:15
haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this pull request Aug 17, 2020
@haoqunjiang
fix: fix Vue 3 + TS + Router template
fc834b3 
Follow up of vuejs#5771

Fixes vuejs#5795
Fixes vuejs#5796
@haoqunjiang haoqunjiang mentioned this pull request Aug 17, 2020
Merged
9 tasks
haoqunjiang added a commit that referenced this pull request Aug 18, 2020
@haoqunjiang
fix: fix Vue 3 + TS + Router template (#5798)
135fdbf 
Follow up of #5771

Fixes #5795
Fixes #5796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong App.vue when create project with Router and TypeScript
1 participant
@haoqunjiang