[cli-plugin-e2e-nightwatch] fixing globals.js import #5387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried scaffolding a new vue-cli project with e2e tests with nightwatch, and it wasn't picking up changes in globals.js. After a bit of digging it seems that the globals.js that was added during the scaffolding wasn't actually being used. Adding this line fixed it.
haoqunjiang
approved these changes
Apr 15, 2020
|
@sodatea thanks for the approval, anything stopping this from being merged? looks like the failure in CI is also present on master |
|
Thanks! I was just too busy with other stuff. This PR is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried scaffolding a new vue-cli project with e2e tests with nightwatch, and it wasn't picking up changes in globals.js. After a bit of digging it seems that the globals.js that was added during the scaffolding wasn't actually being used. Adding this line fixed it.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: