fix(serve): pass devServer sockPath properly to client #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
approved these changes
May 14, 2020
|
Whats the normal release schedule for vue-cli, is there anything in particular that would trigger a patch release? As Id like to know how long I can expect until this fix is released. Cheers, |
|
Need to clean up some other stuff. I'll ship a release (4.4.0, under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
When you change the
devServer.sockPathsetting, one of the requiredwebpack-devserver-clientignores thesockPathsetting. This is visible in your developer console: the local sockjs url connects but the network sockjs fails.This is caused by incorrectly providing the
sockPathto the webpack client. It infers the host and port from the provided URL parameter but not the sockPath, which has to be specified as an additional parameter. This PR removes the path part from thesockjsUrl(as it does nothing) and adds thesockPathas additional param.