Skip to content

Adding noEmit: true is a breaking change and should be a major release version #29

@adamdehaven

Description

@adamdehaven

Adding noEmit: true in #26 should be considered a breaking change and bump the major version.

The comment added with the change, shown below, makes too many assumptions on when the tsconfig is extended and the behavior of the host application.

// Most non-library projects don't need to emit declarations.
// So we add this option by default to make the config more friendly to most users.

Even in the component libraries where we extend @vue/tsconfig/tsconfig.json, we have our own settings for exporting/generating types, etc. via flags that should not be overridden by this extendable configuration.

IMO this change should be reverted as it is too opinionated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions