perf: Avoid doing type gymnastics with JSX.IntrinsicElements
#3259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3226, close #3148, close #3130, close #2533
First I wasn't able to actually reproduce the problem, so please let me know if it doesn't solve the above closed issue. Thanks to @Fuzzyma for helping to investigate, I think the problem is most likely happening in #2685.
In this PR we no longer do type gymnastics with
JSX.IntrinsicElements, so TS type evaluation may be faster.But it also makes the template unable to separate
JSX.IntrinsicElementsand components types, which affects DX in some cases, but I think it is a reasonable trade-off, and it is too expensive to trade performance for it.