Fix options documentation in order-in-components #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
reviewed
Jul 14, 2017
docs/rules/order-in-components.md
Outdated
| 'renderError' | ||
| ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
I think this is actually wrong. Current version seems fine @armano2, why do you want to change it?
There was a problem hiding this comment.
lifecycle_hooks is invalid because it's should be LIFECYCLE_HOOKS
Its defined here rules/order-in-components.js#L25 and used rules/order-in-components.js#L111
if you want to make it work we will have to change
const extendedOrder = order.map(property => groups[property] || property)to
const extendedOrder = order.map(property => groups[property.toUpperCase()] || property)i just copied current configuration from rules
There was a problem hiding this comment.
Ah this one. Okay. Then please update only this attribute in this PR. The rest is fine. In your pasted example there is a { missing. Let's keep the diff obvious :)
michalsnik
approved these changes
Jul 14, 2017
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.