Skip to content

Fix #580 - Fix false positives regarding components inside SVGs #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2018

Conversation

michalsnik
Copy link
Member

This PR addresses the following issue #580

It does few things:

  1. Stops ignoring custom components inside SVGs, so the-component will be reported now:
<template>
  <svg>
    <the-component />
  </svg>
</template>
  1. Allows having SVG known elements inside the HTML namespace and not treating them as components. So for example this component (part of the SVG) will not report that circle should be PascalCase:
<template>
  <circle />
</template>
<script>
  export default {}
</script>

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalsnik LGTM!

@michalsnik michalsnik merged commit f7a4dc0 into master Nov 12, 2018
@michalsnik michalsnik deleted the 580-fix-false-positives-regarding-svg branch November 12, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants