ESLint 6 compatibility

[jtsom]

Tell us about your environment

• ESLint version: 6.0.1
• eslint-plugin-vue version: 5.2.3
• Node version: 12.5.0

Upgrading to ESLint v6 shows warnings when installing:
npm WARN eslint-plugin-vue@5.2.3 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN vue-eslint-parser@5.0.0 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself

[719media]

I hit this same warning. I looked to see if the package.json for vue-eslint-parser@6was using eslint 6 yet (to see if whenever eslint-plugin-vue gets around to updating to vue-eslint-parser@6 it may alleviate the problem), but it's also still peerDependency on eslint 5, so I'm not sure if there are compat reasons that the authors know about which makes this difficult to just change.

[davidpelayo]

It got added to the code at this commit. However, no new version has been released to npm, AFAIK. At least, I still see the node_modules/eslint-plugin-vue/package.json with the following:

{
  "peerDependencies": {
    "eslint": "^5.0.0"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/vuejs/eslint-plugin-vue.git"
  },
  "scripts": {
    "docs:build": "vuepress build docs",
    "docs:watch": "vuepress dev docs",
    "lint": "eslint . --rulesdir eslint-internal-rules",
    "pretest": "npm run lint",
    "preversion": "npm test && npm run update && git add .",
    "start": "npm run test:base -- --watch --growl",
    "test": "nyc npm run test:base -- \"tests/integrations/*.js\" --timeout 60000",
    "test:base": "mocha \"tests/lib/**/*.js\" --reporter dot",
    "update": "node ./tools/update.js",
    "version": "npm run lint -- --fix && git add ."
  },
  "version": "5.2.3"
}

[jpickwell]

@davidpelayo, the v5.2.3 tag was created and published on 2019-06-24. The commit you refer to was created on 2019-07-08. They haven’t published a new version containing that commit.

[jtsom]

Almost a month later now, any chance this will be updated to support ESLint 6 sometime soon??

[kaechele]

Given that it seems to be only a matter of tagging a release and releases usually are made periodically, statistically the chance for seeing a release that contains the fix for this issue is increasingly likely.
Stochastically, given that we have seen a release of this project about once every month in the past, it is extremely likely that this will resolve itself within the next 4 weeks.

[areyes-ut]

This has become a bit more urgent because eslint-utils, a dependency of eslint, has a known vulnerability in it which is fixed in the eslint version 6 suite. Please make a release of eslint-plugin-vue soon(er).

GHSA-3gx7-xhv7-5mx3

[nysos3]

@mysticatea Any hope of a release soon? ❤️ (Especially seeing as you're the one to report the aforementioned vulnerability 👀)

[juhasev]

This is a show stopper for many packages out there. I may have to hold on upgrading because of this. Hopefully eslint-6 compatibility gets out soon!

[limeandcoconut]

Any movement on this? It's an issue

[thebrownfox]

Been watching this issue for a long time and still nothing.

[thebrownfox]

July: It has to be a matter of days
ESLint 6 compatibility in October be like:

[kaidjohnson]

fwiw, we've been using eslint 6 with eslint-plugin-vue for several months now without issue. The peerDependencies are up-to-date but not published to npm in 5.2.3 (sounds like it is included in 5.2.2, though).

Can someone who has rights either a) publish 5.2.4 with the update from #917 which seems to be in 5.2.2 but not 5.2.3 or b) provide some insight into what's holding this up?

[gluons]

Maybe they're waiting for vuejs/vue-eslint-parser#54 to be resolved.