feat: use Intl.getCanonicalLocales check locale
#450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
approved these changes
Feb 29, 2024
Member
haoqunjiang
left a comment
haoqunjiang
left a comment
There was a problem hiding this comment.
Thanks!
Note to myself: the @ts-ignore comment can be removed after upgrading to TypeScript 5.4
|
In future, ts-expect-error is a good alternative to ts-ignore; it'll raise an error when it's no longer needed, so you don't have to remember :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users configure LANG related information by themselves, irregular spelling or capitalization problems may occur. However, I am not sure whether to throw an error directly to terminate the process at this time or just output the error message and continue to perform the following steps. (The current action I take is to print the error message and continue.)
Related commit bb11f04