test: create EffectScope using a factory function
#8844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Aug 15, 2023
Member
sxzz
left a comment
sxzz
left a comment
There was a problem hiding this comment.
I think we can keep the changes of unit tests, but revert runtime code. Seems like we removed new keyword only and but a new import specifier.
Member
Author
Hi, I have rolled back |
sxzz
changed the title
EffectScope using a factory functionEffectScope using a factory function
sxzz
approved these changes
Aug 15, 2023
Size ReportBundles
Usages
|
haoqunjiang
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.