fix(runtime-core): return boolean type when use defineProps to set optional boolean prop

[godxiaoji]

fix #5847 fix #7487

The results are as follows:

const props = defineProps<{
  str?: string;
  bool?: boolean;
}>();
// readonly props.str?: string | undefined
// readonly props.bool: boolean


const propsWithDefaults = withDefaults(
  defineProps<{
    str?: string;
    str1: string;
    bool?: boolean;
    bool1: boolean;
  }>(),
  {
    str: "msg",
    str1: undefined,
    bool: undefined,
    bool1: undefined,
  }
);
// readonly props.str: string
// readonly props.str1?: string | undefined
// readonly props.bool?: boolean | undefined
// readonly props.bool1?: boolean | undefined

[netlify]

❌ Deploy Preview for vuejs-coverage failed.

Name	Link
🔨 Latest commit	bffb1b2
🔍 Latest deploy log	https://app.netlify.com/sites/vuejs-coverage/deploys/63bfa0614bded20008845285

[sxzz]

Consider this case

      boolAndUndefined: boolean | undefined

[sxzz]

Suggested change

	: never]-?: TypeProps[K]
	: never]-?: NotUndefined<TypeProps[K]>

[godxiaoji]

Without NotUndefined, the '-?' will still remove 'undefined'.

[sxzz]

Actually, it won't when there's only boolean | undefined and no ?:

interface T {
  boolAndUndefined: boolean | undefined
}

type Test = {
  [K in keyof T]-?: T[K]
}
// type Test = {
//     boolAndUndefined: boolean | undefined;
// }

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgCrIN4ChnIEYD2BANgIIgAmAqpRDKBBQFz5HERwjIA+yArrXohGWAL5YsYAJ4AHFKggBnMMgC8mHMgDaAaWShkAawhSCMNAF0AtAH4WqXRbFYgA

[godxiaoji]

Thanks, modified.

[sxzz]

This implementation will lead it cannot jump to the declaration by clicking bool of props.bool (props.foo also).

[sxzz]

I'll create a new PR with another implementation.

[yyx990803]

@godxiaoji Thank you very much for the PR - @sxzz came up with a better alternative in #7619 that retains the ability to jump to definition on props properties, but we really appreciate your contribution!

[godxiaoji]

@godxiaoji Thank you very much for the PR - @sxzz came up with a better alternative in #7619 that retains the ability to jump to definition on props properties, but we really appreciate your contribution!

Is my pleasure. @yyx990803 I have a few pr, free also trouble to review #7133 #6827 #6773 #6765.