Skip to content

chore(runtime-core): add isRegExp to check RegExp #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2022
Merged

chore(runtime-core): add isRegExp to check RegExp #6041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eb9683
chore(runtime-core): use `instanceof` to check `RegExp`
webfansplz Jun 1, 2022
4d5ee49
chore: update
Jun 1, 2022
a9ae3b5
Merge branch 'main' into chore-runtime-core
antfu Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/runtime-core/src/components/KeepAlive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
import {
isString,
isArray,
isRegExp,
ShapeFlags,
remove,
invokeArrayFns
Expand Down Expand Up @@ -350,7 +351,7 @@ function matches(pattern: MatchPattern, name: string): boolean {
return pattern.some((p: string | RegExp) => matches(p, name))
} else if (isString(pattern)) {
return pattern.split(',').includes(name)
} else if (pattern.test) {
} else if (isRegExp(pattern)) {
return pattern.test(name)
}
/* istanbul ignore next */
Expand Down
2 changes: 2 additions & 0 deletions packages/shared/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ export const isSet = (val: unknown): val is Set<any> =>

export const isDate = (val: unknown): val is Date =>
toTypeString(val) === '[object Date]'
export const isRegExp = (val: unknown): val is RegExp =>
toTypeString(val) === '[object RegExp]'
export const isFunction = (val: unknown): val is Function =>
typeof val === 'function'
export const isString = (val: unknown): val is string => typeof val === 'string'
Expand Down