Skip to content

fix(shared): Parse string value including a leading number as string value #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(shared): Parse string value including a leading number as string value #4946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/shared/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ export const def = (obj: object, key: string | symbol, value: any) => {
})
}

export const toNumber = (val: any): any => {
const n = parseFloat(val)
return isNaN(n) ? val : n
export const toNumber = (value: any): any => {
const parsedValue = Number(value)
return isNaN(parsedValue) ? value : parsedValue
}

let _globalThis: any
Expand Down