WIP fix(toNumber): fix issue #2598 and add test #2604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmtk1
changed the title
Contributor
|
Do not think |
Alanscut
reviewed
Nov 16, 2020
Contributor
Alanscut
left a comment
Alanscut
left a comment
There was a problem hiding this comment.
test failed, '3.14aa'.match(/\d+(\.\d+)?/) is true.
|
|
||
| export const toNumber = (val: any): any => { | ||
| if (typeof val === 'string') { | ||
| const matched = val.match(/\d+(\.\d+)?/) |
Contributor
There was a problem hiding this comment.
Suggested change
| const matched = val.match(/\d+(\.\d+)?/) | |
| const matched = val.match(/^\d+(\.\d+)?$/) |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
close vuejs#4946 close vuejs#2598 close vuejs#2604 This commit also refactors internal usage of previous loose implementation of `toNumber` to the stricter version where applicable. Use of `looseToNumber` is preserved for `v-model.number` modifier to ensure backwards compatibility and consistency with Vue 2 behavior.
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
close vuejs#4946 close vuejs#2598 close vuejs#2604 This commit also refactors internal usage of previous loose implementation of `toNumber` to the stricter version where applicable. Use of `looseToNumber` is preserved for `v-model.number` modifier to ensure backwards compatibility and consistency with Vue 2 behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what I did