chore(runtime-core): use NO instead of ()=>false

[zhangenming]

I think this code in critical path, So it should be meaningful

Summary by CodeRabbit

• Refactor
  • Improved internal consistency by replacing an inline function with a shared utility function. No changes to user-facing features or behavior.

[coderabbitai]

Walkthrough

An inline anonymous function returning false was replaced with a predefined constant function (NO) in the conditional assignment of canSetSetupRef within the setRef function. This change standardizes the usage of a shared utility without altering any logic or exported/public entity interfaces.

Changes

File(s)	Change Summary
packages/runtime-core/src/rendererTemplateRef.ts	Replaced () => false with the shared constant function NO in a conditional assignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A function once lonely, just saying "no",
Now joins its siblings in a shared code flow.
With NO in its place, the code’s more neat,
Little changes like this make refactors sweet!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c486536 and 6fdb1a5.

📒 Files selected for processing (1)

• packages/runtime-core/src/rendererTemplateRef.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/runtime-core/src/rendererTemplateRef.ts (1)

packages/shared/src/general.ts (1)

• NO (13-13)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed
• GitHub Check: test / e2e-test

🔇 Additional comments (2)

packages/runtime-core/src/rendererTemplateRef.ts (2)

5-5: LGTM! Good use of shared utility.

The import of NO is appropriate and follows Vue's pattern of using shared utilities instead of inline implementations.

---

81-81: Excellent micro-optimization for a critical path.

Replacing the inline () => false with the shared NO constant eliminates repeated function object creation during template ref processing. This is a meaningful optimization since setRef is called frequently during rendering.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB (-5 B)	38.4 kB (-2 B)	34.6 kB (+18 B)
vue.global.prod.js	159 kB (-5 B)	58.6 kB (-3 B)	52.2 kB (-24 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB (-5 B)	18.2 kB (-1 B)	16.7 kB (+4 B)
createApp	54.6 kB (-5 B)	21.2 kB (-1 B)	19.4 kB (+4 B)
createSSRApp	58.8 kB (-5 B)	23 kB (-2 B)	20.9 kB (-9 B)
defineCustomElement	59.6 kB (-5 B)	22.8 kB (-1 B)	20.8 kB (-2 B)
overall	68.7 kB (-5 B)	26.4 kB (-4 B)	24.1 kB (-11 B)

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13695

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13695

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13695

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13695

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13695

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13695

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13695

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13695

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13695

vue

npm i https://pkg.pr.new/vue@13695

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13695

commit: 6fdb1a5