Skip to content

Conversation

edison1105
Copy link
Member

close #12046

Copy link

github-actions bot commented Sep 27, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+3 B) 38.1 kB 34.2 kB (-2 B)
vue.global.prod.js 160 kB (+3 B) 58 kB (+1 B) 51.5 kB (-51 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.6 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB (+3 B) 23.1 kB 21.1 kB (+47 B)
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Sep 27, 2024

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12047

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12047

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12047

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12047

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12047

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12047

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12047

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12047

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12047

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12047

vue

pnpm add https://pkg.pr.new/vue@12047

commit: d0e0b88

@edison1105 edison1105 changed the title fix(transition/ssr): make transition appear work with Suspense fix(transition/ssr): make transition appear work with Suspense in SSR Sep 27, 2024
@@ -385,7 +385,8 @@ export function createHydrationFunctions(
let needCallTransitionHooks = false
if (isTemplateNode(el)) {
needCallTransitionHooks =
needTransition(parentSuspense, transition) &&
transition &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to check parentSuspense during hydration.

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: transition scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 27, 2024
@yyx990803 yyx990803 merged commit f1a4f67 into main Oct 11, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/ssrTranstion branch October 11, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: ssr scope: transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Transition appear> seems not working on SSR
2 participants