chore: disallow optional chaining #10919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
Member
|
But after minification it is not that verbose: https://esbuild.github.io/try/#dAAwLjIxLjQALS10YXJnZXQ9ZXMyMDE2IC0tbWluaWZ5AGE/LmI |
Member
Author
|
See #4882 (comment) |
haoqunjiang
approved these changes
May 29, 2024
lynxlangya
pushed a commit
to lynxlangya/core
that referenced
this pull request
May 30, 2024
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jun 17, 2024
yyx990803
reviewed
Jun 22, 2024
| const root = instance?.subTree | ||
| if ( | ||
| vnode === root || | ||
| // eslint-disable-next-line no-restricted-syntax |
Member
There was a problem hiding this comment.
hydration code actually runs in the browser and shouldn't have been allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow the use of optional chaining (
a?.b,a?.()), except when running on Node.js.