chore: update to ESLint 9 #10705
Merged
chore: update to ESLint 9 #10705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Though `@typescript-eslint/*` haven't officially supported ESLint 9, the remaining issues are not relevant to its usage in this repo, so I patched them in the peer dependency rules. - Flat Config migration takes time so I used `ESLINT_USE_FLAT_CONFIG=false` for now - Optional catch binding is supported since Node.js v10, so I removed the unused `e`s in `release.js` to suppress the `no-unused-vars`` error - `eslint-plugin-i` is now `eslint-plugin-import-x`, I'll migrate it in a later commit - We don't use Jest in this repo, I'll migrate `eslint-plugin-jest` to `eslint-plugin-vitest` in a later commit
Also updates the lint-staged config. Because it doesn't support the shell convention of expanding environment variables, I had to add the `cross-env` package. https://github.com/lint-staged/lint-staged#use-environment-variables-with-linting-commands
Size ReportBundles
Usages
|
In the long run it might get deprecated in favor of `tseslint.config()` typescript-eslint/typescript-eslint#8802 (comment)
haoqunjiang
changed the title
haoqunjiang
added
🧹 p1-chore
lynxlangya
pushed a commit
to lynxlangya/core
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10703
Note that the current stable version of the VS Code ESLint extension doesn't fully support flat config.
microsoft/vscode-eslint#1822 (comment)
You need to switch to the pre-release version for editor support manually.