Skip to content

fix(runtime-core): should not warn when mounting another app in setup #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix(runtime-core): should not warn when mounting another app in setup #10125

merged 2 commits into from
Jan 18, 2024

Conversation

@inottn
Copy link
Contributor

@inottn inottn commented Jan 16, 2024

close #10124

@yyx990803 yyx990803 merged commit 6fa33e6 into vuejs:main Jan 18, 2024
@github-actions
Copy link

github-actions bot commented Jan 18, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.9 kB 34.3 kB 30.9 kB
vue.global.prod.js 147 kB 53.5 kB 47.8 kB

Usages

Name Size Gzip Brotli
createApp 50.3 kB 19.7 kB 17.9 kB
createSSRApp 53.6 kB 21 kB 19.1 kB
defineCustomElement 52.6 kB 20.4 kB 18.6 kB
overall 64 kB 24.8 kB 22.4 kB

@inottn inottn deleted the fix/10124 branch February 1, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mounting another app in the setup may trigger a warning

2 participants

@inottn @yyx990803